Skip to content

HADOOP-19393. [ABFS][Backport to 3.4] Returning FileAlreadyExists Exception for UnauthorizedBlobOverwrite Rename Errors #7403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anujmodi2021 merged 1 commit into from
Feb 24, 2025
Merged

HADOOP-19393. [ABFS][Backport to 3.4] Returning FileAlreadyExists Exception for UnauthorizedBlobOverwrite Rename Errors #7403

anujmodi2021 merged 1 commit into from
Feb 24, 2025

Conversation

@manika137
Copy link
Contributor

@manika137 manika137 commented Feb 19, 2025 •
edited
Loading

Commit on trunk: f1df748
PR on trunk: #7312
Target JIRA: https://issues.apache.org/jira/browse/HADOOP-19393

Description of PR

ABFS driver adheres to Hadoop's expectations which does not allow rename blob overwrites. Recently we came across the case where UnauthorizedBlobOverwrite error (HTTP 403- Access Denied Exception) is thrown for rename overwrites (with SAS authentication).
Remapping this error to FileAlreadyExists exception for better understanding.

Test results added in the comments below.

@manika137
HADOOP-19393. [ABFS] Return FileAlreadyExistsException for Unauthoriz…
3c0d979 
…edBlobOverwrite Rename Errors (apache#7312)

Contributed by Manika Joshi.
@manika137 manika137 marked this pull request as draft February 19, 2025 06:15
@hadoop-yetus
Copy link

hadoop-yetus commented Feb 19, 2025

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 7m 21s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.4 Compile Tests _
+1 💚 mvninstall 22m 21s branch-3.4 passed
+1 💚 compile 0m 20s branch-3.4 passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 compile 0m 22s branch-3.4 passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 checkstyle 0m 21s branch-3.4 passed
+1 💚 mvnsite 0m 27s branch-3.4 passed
+1 💚 javadoc 0m 27s branch-3.4 passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 0m 20s branch-3.4 passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 spotbugs 0m 45s branch-3.4 passed
+1 💚 shadedclient 19m 23s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 18s the patch passed
+1 💚 compile 0m 18s the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javac 0m 19s the patch passed
+1 💚 compile 0m 18s the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 javac 0m 18s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 12s the patch passed
+1 💚 mvnsite 0m 18s the patch passed
+1 💚 javadoc 0m 16s the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 0m 17s the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 spotbugs 0m 42s the patch passed
+1 💚 shadedclient 18m 46s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 2m 1s hadoop-azure in the patch passed.
+1 💚 asflicense 0m 25s The patch does not generate ASF License warnings.
76m 50s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7403/1/artifact/out/Dockerfile
GITHUB PR #7403
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux a80bc8f71946 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.4 / 3c0d979
Default Java Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7403/1/testReport/
Max. process+thread count 552 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7403/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@manika137
Copy link
Contributor Author

manika137 commented Feb 19, 2025 •
edited
Loading

Test Results

============================================================
HNS-OAuth-DFS

[WARNING] Tests run: 165, Failures: 0, Errors: 0, Skipped: 4
[WARNING] Tests run: 775, Failures: 0, Errors: 0, Skipped: 151
[WARNING] Tests run: 171, Failures: 0, Errors: 0, Skipped: 25
[WARNING] Tests run: 262, Failures: 0, Errors: 0, Skipped: 32

============================================================
HNS-SharedKey-DFS

[WARNING] Tests run: 165, Failures: 0, Errors: 0, Skipped: 5
[WARNING] Tests run: 775, Failures: 0, Errors: 0, Skipped: 102
[WARNING] Tests run: 171, Failures: 0, Errors: 0, Skipped: 25
[WARNING] Tests run: 262, Failures: 0, Errors: 0, Skipped: 19

============================================================
NonHNS-SharedKey-DFS

[WARNING] Tests run: 165, Failures: 0, Errors: 0, Skipped: 11
[WARNING] Tests run: 759, Failures: 0, Errors: 0, Skipped: 346
[WARNING] Tests run: 171, Failures: 0, Errors: 0, Skipped: 27
[WARNING] Tests run: 262, Failures: 0, Errors: 0, Skipped: 20

============================================================
AppendBlob-HNS-OAuth-DFS

[WARNING] Tests run: 165, Failures: 0, Errors: 0, Skipped: 4
[WARNING] Tests run: 775, Failures: 0, Errors: 0, Skipped: 156
[WARNING] Tests run: 171, Failures: 0, Errors: 0, Skipped: 49
[WARNING] Tests run: 262, Failures: 0, Errors: 0, Skipped: 32

============================================================
NonHNS-SharedKey-Blob

[WARNING] Tests run: 165, Failures: 0, Errors: 0, Skipped: 11
[WARNING] Tests run: 759, Failures: 0, Errors: 0, Skipped: 286
[WARNING] Tests run: 171, Failures: 0, Errors: 0, Skipped: 28
[WARNING] Tests run: 262, Failures: 0, Errors: 0, Skipped: 20

============================================================
NonHNS-OAuth-DFS

[WARNING] Tests run: 165, Failures: 0, Errors: 0, Skipped: 11
[WARNING] Tests run: 759, Failures: 0, Errors: 0, Skipped: 350
[WARNING] Tests run: 171, Failures: 0, Errors: 0, Skipped: 27
[WARNING] Tests run: 262, Failures: 0, Errors: 0, Skipped: 33

============================================================
NonHNS-OAuth-Blob

[WARNING] Tests run: 165, Failures: 0, Errors: 0, Skipped: 11
[WARNING] Tests run: 759, Failures: 0, Errors: 0, Skipped: 290
[WARNING] Tests run: 171, Failures: 0, Errors: 0, Skipped: 28
[WARNING] Tests run: 262, Failures: 0, Errors: 0, Skipped: 33

============================================================
AppendBlob-NonHNS-OAuth-Blob

[WARNING] Tests run: 165, Failures: 0, Errors: 0, Skipped: 11
[WARNING] Tests run: 759, Failures: 0, Errors: 0, Skipped: 309
[WARNING] Tests run: 171, Failures: 0, Errors: 0, Skipped: 52
[WARNING] Tests run: 262, Failures: 0, Errors: 0, Skipped: 33

============================================================
HNS-Oauth-DFS-IngressBlob

[WARNING] Tests run: 165, Failures: 0, Errors: 0, Skipped: 4
[WARNING] Tests run: 775, Failures: 0, Errors: 0, Skipped: 280
[WARNING] Tests run: 171, Failures: 0, Errors: 0, Skipped: 25
[WARNING] Tests run: 262, Failures: 0, Errors: 0, Skipped: 32

============================================================
NonHNS-OAuth-DFS-IngressBlob

[WARNING] Tests run: 165, Failures: 0, Errors: 0, Skipped: 11
[WARNING] Tests run: 759, Failures: 0, Errors: 0, Skipped: 348
[WARNING] Tests run: 171, Failures: 0, Errors: 0, Skipped: 27
[WARNING] Tests run: 262, Failures: 0, Errors: 0, Skipped: 33

@manika137 manika137 marked this pull request as ready for review February 19, 2025 12:29
anujmodi2021
anujmodi2021 approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@anujmodi2021 anujmodi2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Backport PR from trunk

@anujmodi2021 anujmodi2021 merged commit 461276a into apache:branch-3.4 Feb 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anujmodi2021 anujmodi2021 anujmodi2021 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manika137 @hadoop-yetus @anujmodi2021